Skip to content

London |ITP- Jan-2026| Damian Dunkley |Sprint 3 |quote-generator#1038

Closed
DamianDL wants to merge 9 commits intoCodeYourFuture:mainfrom
DamianDL:Sprint3-quote
Closed

London |ITP- Jan-2026| Damian Dunkley |Sprint 3 |quote-generator#1038
DamianDL wants to merge 9 commits intoCodeYourFuture:mainfrom
DamianDL:Sprint3-quote

Conversation

@DamianDL
Copy link
Copy Markdown

@DamianDL DamianDL commented Mar 18, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Updated Code to meet requirements;

  1. Update to quote.js, to select quote from list, then insert into the quote generator the quote and author.
  2. Creation of style.css to make orange background, white foreground and orange txt as per picture of quote generator.

Questions

Please review

@github-actions

This comment has been minimized.

Sign in to view
4 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@DamianDL DamianDL added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. javascript Pull requests that update javascript code labels Mar 18, 2026
cjyuan
cjyuan reviewed Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Can you update index.html so that it fully meets the requirements specified in the README.md file.
I will mark this PR as complete first.

Comment thread Sprint-3/quote-generator/index.html
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed updating part of index.html according to an instruction in readme.md.

Copy link
Copy Markdown
Author

@DamianDL DamianDL Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing @cjyuan. Index.html updated as per readme, new commit made. Thanks

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 26, 2026
@DamianDL DamianDL mentioned this pull request Mar 30, 2026
Open
@illicitonion
Copy link
Copy Markdown
Member

illicitonion commented May 4, 2026

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. javascript Pull requests that update javascript code Module-Data-Groups The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DamianDL @illicitonion @cjyuan