Skip to content

Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 1| Coursework/Sprint1#1063

Closed
Ayogit1 wants to merge 3 commits intoCodeYourFuture:mainfrom
Ayogit1:Sprint-1
Closed

Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 1| Coursework/Sprint1#1063
Ayogit1 wants to merge 3 commits intoCodeYourFuture:mainfrom
Ayogit1:Sprint-1

Conversation

@Ayogit1
Copy link
Copy Markdown

@Ayogit1 Ayogit1 commented Mar 21, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completion of Sprint 1

@github-actions

This comment has been minimized.

Sign in to view
@Ayogit1 Ayogit1 changed the title Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 1| Coursework/Sprint1 Needs review Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 1| Coursework/Sprint1 Mar 21, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 21, 2026
cjyuan
cjyuan reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed updating a few files in this Sprint-1 exercise. Can you check the instructions in README.md and update the files you missed?

Comment thread Sprint-1/fix/median.js Outdated
Comment thread Sprint-1/implement/sum.js
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 24, 2026
@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 17, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 18, 2026

You missed updating a few files in this Sprint-1 exercise. Can you check the instructions in README.md and update the files you missed?

You are also supposed to implement the tests in the .test.js files.

Since this PR is not a required evidence in Step 3 submission, you can complete this PR when you have time.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 18, 2026
@Ayogit1
Copy link
Copy Markdown
Author

Ayogit1 commented Apr 20, 2026

@cjyuan
You mentioned that this PR is not a required evidence in Step 3 submission, hence I can complete this PR when you have time.

Are you happy to make this complete now as I have few days to finish up.

Thanks for all your help.

image

@Ayogit1 Ayogit1 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 20, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 20, 2026 •
edited
Loading

I won't mark this as complete for the reason I stated. And it won't affect your Step 3 completion.

If you have made changes, you will need to push them to GitHub.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 20, 2026
@Ayogit1
Copy link
Copy Markdown
Author

Ayogit1 commented Apr 20, 2026

Thanks, changes have now been push them to GitHub.

@Ayogit1 Ayogit1 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 20, 2026
cjyuan
cjyuan reviewed Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Comment thread Sprint-1/implement/dedupe.test.js
test("given an array with no duplicates, it returns a copy of the original array", () => {
const input = [1, 2, 3, "a", "b"];
const result = dedupe(input);
expect(result).toEqual(input);
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test on line 15 is not reliable because input could be mutated by the function. As a result, there is a chance that result and input could hold identical BUT incorrect elements.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 21, 2026
@Ayogit1 Ayogit1 mentioned this pull request Apr 21, 2026
Open
@illicitonion
Copy link
Copy Markdown
Member

illicitonion commented May 4, 2026

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ayogit1 @cjyuan @illicitonion