Skip to content

Manchester | 26-ITP-Jan | Khalidbih| Sprint 1| Data-Groups#1068

Closed
khalidbih wants to merge 8 commits intoCodeYourFuture:mainfrom
khalidbih:coursework/sprint-1-clean
Closed

Manchester | 26-ITP-Jan | Khalidbih| Sprint 1| Data-Groups#1068
khalidbih wants to merge 8 commits intoCodeYourFuture:mainfrom
khalidbih:coursework/sprint-1-clean

Conversation

@khalidbih
Copy link
Copy Markdown

@khalidbih khalidbih commented Mar 21, 2026

Self checklist :

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist :

Completed all Sprint-1 exercises with tests.

@github-actions

This comment has been minimized.

Sign in to view
@khalidbih khalidbih added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Mar 21, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 21, 2026
@github-actions

This comment has been minimized.

Sign in to view
@khalidbih khalidbih changed the title Manchester l 26-ITP-Jan l khalidbih l Sprint 1 l Coursework/Sprint-1 Manchester | 26-ITP-Jan | Khalidbih | Sprint 1 | Data Groups Mar 21, 2026
@khalidbih khalidbih changed the title Manchester | 26-ITP-Jan | Khalidbih | Sprint 1 | Data Groups Manchester | 26-ITP-Jan | Khalidbih| Sprint-1| Data-Groups Mar 21, 2026
@khalidbih khalidbih added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 21, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 21, 2026
@github-actions

This comment has been minimized.

Sign in to view
@khalidbih khalidbih changed the title Manchester | 26-ITP-Jan | Khalidbih| Sprint-1| Data-Groups Manchester | 26-ITP-Jan | Khalidbih| Sprint 1| Data-Groups Mar 21, 2026
@khalidbih khalidbih added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 21, 2026
cjyuan
cjyuan reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed updating a file in the "refactor" subfolder.

Comment thread Sprint-1/fix/median.js Outdated
Comment thread Sprint-1/implement/max.test.js
Comment thread Sprint-1/implement/sum.test.js
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 24, 2026
@khalidbih khalidbih added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 25, 2026
@khalidbih
Copy link
Copy Markdown
Author

khalidbih commented Mar 25, 2026

You missed updating a file in the "refactor" subfolder.

Thank you for the feedback! I’m not sure which file in the refactor subfolder needs updating. Could you clarify so I can fix it? I also want to be safe to fix the problem

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Mar 25, 2026 •
edited
Loading

The instruction is in the Sprint-1/readme.md and also in the comments of the files in the "refactor" folder.

Only a small change is expected.

Other changes look good.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 25, 2026
@khalidbih
Copy link
Copy Markdown
Author

khalidbih commented Mar 25, 2026

The instruction is in the Sprint-1/readme.md and also in the comments of the files in the "refactor" folder.

Only a small change is expected.

Other changes look good.

Thank you, I’ve located the refactor folder and added the required changes.

@khalidbih khalidbih added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 25, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Mar 25, 2026

All good now. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 25, 2026
@khalidbih
Copy link
Copy Markdown
Author

khalidbih commented Mar 25, 2026

All good now. Well done.

Thank you so much.

@khalidbih khalidbih mentioned this pull request Apr 9, 2026
Open
@illicitonion
Copy link
Copy Markdown
Member

illicitonion commented May 4, 2026

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khalidbih @cjyuan @illicitonion