Skip to content

Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 2| Coursework/Sprint2#1072

Closed
Ayogit1 wants to merge 3 commits intoCodeYourFuture:mainfrom
Ayogit1:Sprint-2
Closed

Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 2| Coursework/Sprint2#1072
Ayogit1 wants to merge 3 commits intoCodeYourFuture:mainfrom
Ayogit1:Sprint-2

Conversation

@Ayogit1
Copy link
Copy Markdown

@Ayogit1 Ayogit1 commented Mar 22, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Sprint 2 completed

@github-actions

This comment has been minimized.

4 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 22, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 22, 2026
@Ayogit1 Ayogit1 changed the title Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 1| Coursework/Sprint2 Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 2| Coursework/Sprint2 Mar 22, 2026
@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 22, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This exercise also expects the *.test.js files in the "implement" folder to be updated. There are tests to be implemented.

Comment thread Sprint-2/implement/contains.js Outdated
Comment thread Sprint-2/implement/contains.js Outdated
Comment thread Sprint-2/implement/tally.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 25, 2026
@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 12, 2026
Comment thread Sprint-2/implement/contains.test.js Outdated
@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 12, 2026
@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 17, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 18, 2026

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 18, 2026
@illicitonion
Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants