London | ITP-JAN-2026 | Said Fayaz Sadat | Sprint 3 | coursework/Quote-generator#1086
Closed
fayaz551 wants to merge 6 commits intoCodeYourFuture:mainfrom
Closed
London | ITP-JAN-2026 | Said Fayaz Sadat | Sprint 3 | coursework/Quote-generator#1086fayaz551 wants to merge 6 commits intoCodeYourFuture:mainfrom
fayaz551 wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
fayaz551
added
the
Needs Review
Luro91
added
Review in progress
Luro91
reviewed
Apr 6, 2026
| const quoteTxt = document.querySelector("#quote"); | ||
| const quoteAuthor = document.querySelector("#author"); | ||
| const autoPlay = document.querySelector("#auto-play"); | ||
| const autoPlayTxt = document.querySelector("#auto-play-txt"); |
There was a problem hiding this comment.
On the html page I don't see any button to start autoplay
Author
There was a problem hiding this comment.
updated the code with md file requirement to toggle on/off and show quotes every 60 sec.
| initaliseSite(); | ||
| autoPlay.addEventListener("change", () => { | ||
| if (autoPlay.checked) { | ||
| console.log("ON"); |
There was a problem hiding this comment.
Debugging logs should be removed in the final code
Author
There was a problem hiding this comment.
removed, thanks for pointing it out.
Luro91
added
Reviewed
…file to make the toggle auto-play work properly.
fayaz551
added
Needs Review
Luro91
reviewed
Apr 8, 2026
Comment on lines
+15
to
+20
| <div class="autoplay-container"> | ||
| <input type="checkbox" id="auto-play" /> | ||
| <label for="auto-play">Enable Auto-Play</label> | ||
|
|
||
| <p id="auto-play-txt">Auto-Play: OFF</p> | ||
| </div> |
There was a problem hiding this comment.
How could you ensure that the code is formatted with the correct indentation?
Author
There was a problem hiding this comment.
by using prettier extension.
updated the file for correct indentation.
Luro91
added
Reviewed
fayaz551
added
Needs Review
Luro91
reviewed
Apr 15, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done the code works correctly and is nicely formatted
Luro91
added
Complete
This was referenced Apr 15, 2026
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
updated the html
styled it with css
implemented DOM to quotes.js
Questions
n/a