London|26-ITP-January|Alexandru Pocovnicu|Sprint 1|Data Groups

Sprint-1/fix/median.js

@@ -6,8 +6,25 @@
 // or 'list' has mixed values (the function is expected to sort only numbers).
 
 function calculateMedian(list) {
-  const middleIndex = Math.floor(list.length / 2);
-  const median = list.splice(middleIndex, 1)[0];
+  if (!Array.isArray(list)) {
+    return null;
+  }
+
+  const filteredList = list.filter((x) => typeof x === "number");
+  const sortedList = filteredList.sort((a, b) => a - b);
+  const middleIndex = Math.floor(sortedList.length / 2);
+
+  if (filteredList.length === 0) {
+    return null;
+  }
+
+  let median = 0;
+  if (sortedList.length % 2 === 0) {
+    median = (sortedList[middleIndex - 1] + sortedList[middleIndex]) / 2;
+  } else {
+    median = sortedList[middleIndex];
+  }
+
   return median;
 }
 

Sprint-1/implement/dedupe.js

@@ -1 +1,14 @@
-function dedupe() {}
+function dedupe(arr) {
+  if (arr.length === 0) {
+    return [];
+  }
+  let newArr = [];
+  for (let element of arr) {
+    if (!newArr.includes(element)) {
+      newArr.push(element);
+    }
+  }
+  return newArr;
+}
+
+module.exports = dedupe;

Sprint-1/implement/dedupe.test.js

@@ -3,7 +3,7 @@ const dedupe = require("./dedupe.js");
 Dedupe Array
 
 📖 Dedupe means **deduplicate**
-
+ 
 In this kata, you will need to deduplicate the elements of an array
 
 E.g. dedupe(['a','a','a','b','b','c']) target output: ['a','b','c']
@@ -16,12 +16,30 @@ E.g. dedupe([1, 2, 1]) target output: [1, 2]
 // Given an empty array
 // When passed to the dedupe function
 // Then it should return an empty array
-test.todo("given an empty array, it returns an empty array");
+test("given an empty array, it returns an empty array",()=>{
+    const array=[]
+    const currentOutput=dedupe(array)
+    const targetOutput=[]
+    expect(currentOutput).toEqual(targetOutput)
+});
 
 // Given an array with no duplicates
 // When passed to the dedupe function
 // Then it should return a copy of the original array
+test("given an array with no duplicates, it returns a copy of the original  array", () => {
+  const array = [1,"d",6];
+  const currentOutput = dedupe(array);
+  const targetOutput = [1,"d",6];
+  expect(currentOutput).toEqual(targetOutput);
+  expect(currentOutput).not.toBe(array)
+});
 
 // Given an array with strings or numbers
 // When passed to the dedupe function
 // Then it should remove the duplicate values, preserving the first occurence of each element
+test("given an array with strings or numbers, it removes the duplicate values, preserving the first occurence of each element", () => {
+  const array = [1, "d", 6,1,5,"d",null];
+  const currentOutput = dedupe(array);
+  const targetOutput = [1, "d", 6,5,null];
+  expect(currentOutput).toEqual(targetOutput);
+});

Sprint-1/implement/max.js

@@ -1,4 +1,8 @@
 function findMax(elements) {
+  const filteredElements = elements.filter(
+    (x) => typeof x === "number" && !Number.isNaN(x)
+  );
+  return  Math.max(...filteredElements)
 }
 
 module.exports = findMax;

Sprint-1/implement/max.test.js

@@ -16,28 +16,69 @@ const findMax = require("./max.js");
 // When passed to the max function
 // Then it should return -Infinity
 // Delete this test.todo and replace it with a test.
-test.todo("given an empty array, returns -Infinity");
+test("given an empty array, returns -Infinity", () => {
+  const array = [];
+  const currentOutput = findMax(array);
+  const targetOutput = -Infinity;
+  expect(currentOutput).toEqual(targetOutput);
+});
 
 // Given an array with one number
 // When passed to the max function
 // Then it should return that number
+test("given an  array with one number, returns -that number", () => {
+  const array = [3];
+  const currentOutput = findMax(array);
+  const targetOutput = 3;
+  expect(currentOutput).toEqual(targetOutput);
+});
 
 // Given an array with both positive and negative numbers
 // When passed to the max function
 // Then it should return the largest number overall
+test("given an array with both positive and negative numbers, returns -the largest number overall ", () => {
+  const array = [3.5, -5, 7, -9];
+  const currentOutput = findMax(array);
+  const targetOutput = 7;
+  expect(currentOutput).toEqual(targetOutput);
+});
 
 // Given an array with just negative numbers
 // When passed to the max function
 // Then it should return the closest one to zero
+test("given an array with just negative numbers, return the closest one to 0", () => {
+  const array = [-5, -1, -7.6, -3];
+  const currentOutput = findMax(array);
+  const targetOutput = -1;
+  expect(currentOutput).toEqual(targetOutput);
+});
 
 // Given an array with decimal numbers
 // When passed to the max function
 // Then it should return the largest decimal number
+test("given an array with decimal numbers, return the largest decimal", () => {
+  const array = [-5.9, -1.8, -7.6, -3.2];
+  const currentOutput = findMax(array);
+  const targetOutput = -1.8;
+  expect(currentOutput).toEqual(targetOutput);
+});
 
 // Given an array with non-number values
 // When passed to the max function
 // Then it should return the max and ignore non-numeric values
+test("given an array with non-number values, returns the max number", () => {
+  const array = [-5, -1, "k", -7.6, null, -3];
+  const currentOutput = findMax(array);
+  const targetOutput = -1;
+  expect(currentOutput).toEqual(targetOutput);
+});
 
 // Given an array with only non-number values
 // When passed to the max function
 // Then it should return the least surprising value given how it behaves for all other inputs
+test("given an array with only non-numbers, returns -Infinity", () => {
+  const array = [false, "k", "-7.6", null, {}, NaN];
+  const currentOutput = findMax(array);
+  const targetOutput = -Infinity;
+  expect(currentOutput).toEqual(targetOutput);
+});

Sprint-1/implement/sum.js

@@ -1,4 +1,13 @@
 function sum(elements) {
+  const filteredElements = elements.filter(
+    (x) => typeof x === "number" && !Number.isNaN(x)
+  );
+
+  if (filteredElements.length === 0) {
+    return 0;
+  }
+  return filteredElements.reduce((a, b) => a + b);
 }
 
+
 module.exports = sum;

Sprint-1/implement/sum.test.js

@@ -3,7 +3,7 @@
 In this kata, you will need to implement a function that sums the numerical elements of an array
 
 E.g. sum([10, 20, 30]), target output: 60
-E.g. sum(['hey', 10, 'hi', 60, 10]), target output: 80 (ignore any non-numerical elements)
+E.g. sum(['hey', 10, 'hi', 60, 10]), target output: 80 (ignore any non-numerical elements) 
 */
 
 const sum = require("./sum.js");
@@ -13,24 +13,59 @@ const sum = require("./sum.js");
 // Given an empty array
 // When passed to the sum function
 // Then it should return 0
-test.todo("given an empty array, returns 0")
+test("given an empty array, returns 0", () => {
+  const array = [];
+  const currentOutput = sum(array);
+  const targetOutput = 0;
+  expect(currentOutput).toEqual(targetOutput);
+});
 
 // Given an array with just one number
 // When passed to the sum function
 // Then it should return that number
+test("given an array with just one number, return the number", () => {
+  const array = [5];
+  const currentOutput = sum(array);
+  const targetOutput = 5;
+  expect(currentOutput).toEqual(targetOutput);
+});
 
 // Given an array containing negative numbers
 // When passed to the sum function
 // Then it should still return the correct total sum
+test("given an array containig negative numbers, return the total of the numbers", () => {
+  const array = [-5, -9, -3];
+  const currentOutput = sum(array);
+  const targetOutput = -17;
+  expect(currentOutput).toEqual(targetOutput);
+});
 
 // Given an array with decimal/float numbers
 // When passed to the sum function
 // Then it should return the correct total sum
+test("given an array containig decimalnumbers, return the total of the numbers", () => {
+  const array = [-5.5, 9, -3];
+  const currentOutput = sum(array);
+  const targetOutput = 0.5;
+  expect(currentOutput).toEqual(targetOutput);
+});
 
 // Given an array containing non-number values
 // When passed to the sum function
 // Then it should ignore the non-numerical values and return the sum of the numerical elements
+test("given an array containig non-number values,ignore the non-numerical values and return the total of the numbers", () => {
+  const array = [5, "s", null, NaN, -9, -3];
+  const currentOutput = sum(array);
+  const targetOutput = -7;
+  expect(currentOutput).toEqual(targetOutput);
+});
 
 // Given an array with only non-number values
 // When passed to the sum function
 // Then it should return the least surprising value given how it behaves for all other inputs
+test("given an array containig only non-number values, return 0", () => {
+  const array = ["s", null, NaN, "-3", true];
+  const currentOutput = sum(array);
+  const targetOutput = 0;
+  expect(currentOutput).toEqual(targetOutput);
+});

Sprint-1/refactor/includes.js

@@ -1,8 +1,7 @@
 // Refactor the implementation of includes to use a for...of loop
 
 function includes(list, target) {
-  for (let index = 0; index < list.length; index++) {
-    const element = list[index];
+  for (let element of list) {
     if (element === target) {
       return true;
     }