Skip to content

London | 26-ITP-January | Eugenie Ahangama | Sprint 2 | Data Groups#983

Closed
Eugenie-A wants to merge 22 commits intoCodeYourFuture:mainfrom
Eugenie-A:feature/sprint-2
Closed

London | 26-ITP-January | Eugenie Ahangama | Sprint 2 | Data Groups#983
Eugenie-A wants to merge 22 commits intoCodeYourFuture:mainfrom
Eugenie-A:feature/sprint-2

Conversation

@Eugenie-A
Copy link
Copy Markdown

@Eugenie-A Eugenie-A commented Mar 8, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed multiple JavaScript implementation bugs across several exercises (address, author, recipe)
  • Added predictions and explanations for each problem to show understanding
  • Implemented and tested a contains function
  • Implemented and tested a lookup function
  • Fixed parseQueryString function and wrote additional edge case tests to cover various scenarios
  • Implemented and tested a tally function
  • Answered questions about the broken invert function to explain why it wasn't working
  • Fixed the invert function and added module.exports which was missing
  • Wrote test cases for invert to prove the fix works correctly

Questions

What is the difference between dot notation and bracket notation?

Eugenie-A added 18 commits March 4, 2026 00:28
@Eugenie-A
Fixed object property access using dot notation + added prediction an…
14a2f59 
…d explanation
@Eugenie-A
Fixed non-iterable object with Object.values + added prediction and e…
ebab27d 
…xplanation
@Eugenie-A
Fixed object interpolation, loop ingredients + added prediction and e…
af62090 
…xplanation
@Eugenie-A
Updated my prediction and explanation for this problem
4c8181e
@Eugenie-A
Updated the prediciton and explanation of this problem
e5a0167
@Eugenie-A
Added tests for contains function
461e87e
@Eugenie-A
Added contains.js implementation
371eb7e
@Eugenie-A
Added tests for the lookup function
21e1adc
@Eugenie-A
Implemented lookup.js function
9e7a052
@Eugenie-A
Fixed parseQueryString value parsing + filter empty pairs
5bd4e7e
@Eugenie-A
fix: split on first = only to correctly parse values containing =
6b31d1d
@Eugenie-A
test: added edge case tests for parseQueryString and fixed typo in ag…
a4b781b 
…e value
@Eugenie-A
Added implementation for tally
8953ba6
@Eugenie-A
added test cases to reflect the function
17d8641
@Eugenie-A
Answered a to d questions
86ed817
@Eugenie-A
Fix: Added missing module.exports to invert
ddd29d3
@Eugenie-A
Answered question e
e604821
@Eugenie-A
Added test cases for invert.js
846db55
@Eugenie-A Eugenie-A added 🏕 Priority Mandatory This work is expected 🐂 Size Medium 1-4 hours 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Submit:PR Module-Data-Groups The name of the module. Core This is a core task and should be completed by all trainees labels Mar 8, 2026
@Eugenie-A Eugenie-A mentioned this pull request Mar 8, 2026
Open
cjyuan
cjyuan reviewed Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code well written.

I only have a few suggestions.

Comment thread Sprint-2/implement/contains.js Outdated
Comment thread Sprint-2/implement/tally.js Outdated
Comment thread Sprint-2/interpret/invert.test.js
Comment thread Sprint-2/implement/querystring.js
Comment thread Sprint-2/implement/contains.test.js
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 18, 2026
@Eugenie-A Eugenie-A added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 19, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Mar 19, 2026

Changes are all good, and thanks for the clear explanations. Excellent job.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 19, 2026
@illicitonion
Copy link
Copy Markdown
Member

illicitonion commented May 4, 2026

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Core This is a core task and should be completed by all trainees Module-Data-Groups The name of the module. 🏕 Priority Mandatory This work is expected 🐂 Size Medium 1-4 hours 📅 Sprint 2 Assigned during Sprint 2 of this module Submit:PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eugenie-A @cjyuan @illicitonion