London|26-ITP-January|Alexandru Pocovnicu|Sprint 3| quote generator app by alexandru-pocovnicu · Pull Request #984 · CodeYourFuture/Module-Data-Groups

alexandru-pocovnicu · 2026-03-09T10:10:42Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

wrote code to show random quote and author

…ent listeners for better readability

takanocap · 2026-03-18T21:56:50Z

 // call pickFromArray with the quotes array to check you get a random quote
+
+function chooseQuote() {
+  const randomQuote = quotes[Math.floor(Math.random() * quotes.length)];


welldone you have done a good job just a few things:
can we make the line easy to understand research KISS and SOC and DRY. can we do something to avoid repeating the line 496? its used in line 20 too

takanocap · 2026-03-18T21:58:33Z

+let interval = null;
+autoGenerate.addEventListener("change", () => {
+  if (autoGenerate.checked) {
+    interval = setInterval(chooseQuote, 2000);


what doeas 2000 mean? what are magic numbers ? and how can we handle magic numbers ?

takanocap · 2026-03-18T22:04:46Z

+  const randomQuote = quotes[Math.floor(Math.random() * quotes.length)];
+
+  const quote = document.getElementById("quote");
+  quote.innerText = randomQuote.quote;


can we use textContent instead of innerText and why ?
what happens if quote is null ?

…ariable for auto-generate functionality

alexandru-pocovnicu · 2026-03-20T20:29:18Z

thank you

kyle-tightest · 2026-04-11T12:33:34Z

+  const randomQuote = pickFromArray(quotes)
+
+  const quote = document.getElementById("quote");
+  if(quote!==null){


please check spacing here and elsewhere, use the style guide as reference

kyle-tightest · 2026-04-11T12:36:07Z

+    interval = setInterval(chooseQuote, changeQuoteInterval);
+  } else {
+    clearInterval(interval);
+    interval = null;


this line may not be necessary, try removing it and see if it works?

which line? the "if" starts the interval and without the "else" the interval doesn't stop even after the box is unchecked

the line that this comment is on, line 521 which says interval = null;

alexandru-pocovnicu · 2026-04-22T16:38:45Z

thank you

illicitonion · 2026-05-04T20:23:59Z

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

alexandru-pocovnicu added 3 commits March 8, 2026 19:00

update title

df37abd

Add functionality to display a random quote on page load

31fcc7d

add button functionality for new quotes

670779a

alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 9, 2026

alexandru-pocovnicu added 4 commits March 9, 2026 11:18

replace pickFromArray with direct random selection from quotes array

0015e40

Add auto-play functionality to display quotes at intervals

be903f2

Fix HTML doctype and add auto-generate toggle checkbox

17571ba

Refactor quote selection logic into a reusable function and update ev…

ea60dd5

…ent listeners for better readability

takanocap suggested changes Mar 18, 2026

View reviewed changes

takanocap added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 18, 2026

alexandru-pocovnicu added 3 commits March 20, 2026 20:16

Refactor quote selection to use pickFromArray for improved randomness

405bec9

Fix null checks for quote and author elements and refactor interval v…

828dc03

…ariable for auto-generate functionality

Use textContent instead of innerText for quote and author elements

f41fe77

alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 20, 2026

alexandru-pocovnicu requested a review from takanocap April 6, 2026 19:23

kyle-tightest reviewed Apr 11, 2026

View reviewed changes

Fix formatting and improve readability in chooseQuote function

da857e3

alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 12, 2026

alexandru-pocovnicu added 2 commits April 12, 2026 21:28

Fix formatting and spacing in auto-generate event listener

a17fc2b

delete unnecessary code

e0c8d35

alexandru-pocovnicu requested a review from kyle-tightest April 18, 2026 16:04

alexandru-pocovnicu mentioned this pull request Apr 19, 2026

26-ITP-January| Data groups | Alexandru Pocovnicu alexandru-pocovnicu/My-Coursework-Planner#89

Open

kyle-tightest removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 22, 2026

kyle-tightest added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Apr 22, 2026

illicitonion closed this May 4, 2026

Uh oh!

Conversation

alexandru-pocovnicu commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexandru-pocovnicu commented Mar 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexandru-pocovnicu commented Apr 22, 2026

Uh oh!

illicitonion commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alexandru-pocovnicu commented Mar 9, 2026 •

edited

Loading