Skip to content

London | 26-ITP-January | Mouawia Elkhalifa | Sprint 1 | Module Data Groups#987

Closed
MouawiaElkhalifa wants to merge 2 commits intoCodeYourFuture:mainfrom
MouawiaElkhalifa:sprint-1
Closed

London | 26-ITP-January | Mouawia Elkhalifa | Sprint 1 | Module Data Groups#987
MouawiaElkhalifa wants to merge 2 commits intoCodeYourFuture:mainfrom
MouawiaElkhalifa:sprint-1

Conversation

@MouawiaElkhalifa
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed Sprint 1 exercises:

  • Implemented sum function
  • Implemented max function
  • Implemented dedupe function
  • Fixed median function
  • Refactored includes function

All tests are passing (45/45).

@MouawiaElkhalifa MouawiaElkhalifa added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 10, 2026
Comment thread Sprint-1/fix/median.js Outdated
Comment thread Sprint-1/fix/median.js Outdated
Comment thread Sprint-1/implement/dedupe.test.js
Comment thread Sprint-1/implement/max.test.js
Comment thread Sprint-1/implement/sum.test.js
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 19, 2026
@MouawiaElkhalifa MouawiaElkhalifa added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 22, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Mar 23, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 23, 2026
@illicitonion
Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants