London | 26-ITP-Jan | Oussama Mouggal | Sprint 3 | Quote generator app#991
Closed
Oussama-Mouggal wants to merge 6 commits intoCodeYourFuture:mainfrom
Closed
London | 26-ITP-Jan | Oussama Mouggal | Sprint 3 | Quote generator app#991Oussama-Mouggal wants to merge 6 commits intoCodeYourFuture:mainfrom
Oussama-Mouggal wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Oussama-Mouggal
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Oussama-Mouggal
added
the
Needs Review
A-O-Emmanuel
added
Review in progress
A-O-Emmanuel
left a comment
A-O-Emmanuel
left a comment
There was a problem hiding this comment.
Your app works, but when i tick the auto play box, it does not work. Also consider adding comments to your code, not necessarily line by line, but when you have a function a comment explaining what the function does is good practice.
A-O-Emmanuel
added
Reviewed
Author
|
Thanks for the feedback. I fixed autoplay so when the checkbox is turned ON it immediately shows a new quote and continues rotating every 60 seconds. I also updated the quote selection to avoid consecutive duplicate quotes, which could make autoplay look inactive. Additionally, I added function-level comments in quotes.js to improve readability and maintainability. Thanks very much |
…autoplay functionality
Oussama-Mouggal
added
the
Needs Review
A-O-Emmanuel
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I changed the project title
I added a function to display a random quote and author on every refresh
Changed Css to match the exercise layout
Stretch: added an auto play button