London | 26-ITP-Jan | Damian Dunkley | Sprint 2 | Data-Groups by DamianDL · Pull Request #993 · CodeYourFuture/Module-Data-Groups

DamianDL · 2026-03-11T11:58:06Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

All Sprint 2 exercises updated and code changed

Questions

Please review. If Invert is not correct- changing the function to make it work and putting in naive consol.log tests, please provide some details of what is required? Thanks

… function to remember key syntax and functionality

…appy path

cjyuan

You did a good job in rejecting invalid parameters in all functions.
I only have some suggestions.

cjyuan · 2026-03-20T12:40:17Z

+   !!obj && // confirm that obj is not null or undefined. If undefined or null, return false.
+   typeof obj === "object" && // confirm that obj is an object. If not an object, return false.
+   !Array.isArray(obj) && // confirm that obj is not an array. If an array, return false.
+   Object.prototype.hasOwnProperty.call(obj, prop)// check if the object has the property. If it does, return true; otherwise, return false.


Could also use Object.hasOwn().

Removed the for loop, replaced with a console.log... .join construction.

Removed the for loop, replaced with a console.log... .join construction.

Changed Object.prototype.hasOwnProperty() with just Object.hasOwnProperty() to simplify code

I meant, we can also use Object.hasOwn(obj, prop).

cjyuan · 2026-03-20T12:44:09Z

 // Then it should return false or throw an error
+test("contains returns false for invalid input types", () => {
+  const arr = [1, 2, 3];
+  expect(contains(arr, "0")).toBe(false); // Arrays do not have properties like objects, so it should return false


Note: An array is a kind of objects and its indexes are its keys (properties).

So for an implementation that does not check if the given value is an array using Array.isArray(), contains([1, 2, 3], "0") could have returned true.

I think that you're saying that my use of !Array.isArray(obj) as a check only works because I have included the property and if I had !Array.isArray(), this would allow 0 to be found in an array of 1, 2, 3 because 1 has a property of "0". Have I understood that correctly or are you expecting me to make changes? Thanks

Sorry that my comment wasn't clear enough.

I meant say the description given in the comment is not quite correct.

// Arrays do not have properties like objects, so it should return false

The function should return false because the first argument is an array (and not because it does not have properties).

…oups into sprint-2

…just Object.hasOwnProperty() to simplify code

cjyuan · 2026-03-24T15:58:22Z

Changes look good. Well done.

illicitonion · 2026-05-04T20:23:39Z

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

DamianDL added 6 commits March 2, 2026 12:14

updates to Sprint1/fix dedupe function and test

a0f6c7e

updates to sprint 2 debug address

ed88192

updates to sprint 2 debug author

bc4aae5

updates to sprint 2 debug recipe

9d340fe

updates to sprint 2 implement Contains and tested ok

95b92ba

updates to sprint 2 implement/contains comments added to each line of…

1af24f2

… function to remember key syntax and functionality

This comment has been minimized.

Sign in to view

DamianDL added 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Data-Groups The name of the module. labels Mar 11, 2026

This comment has been minimized.

Sign in to view

DamianDL added 10 commits March 11, 2026 12:15

restoring Sprint1 files from main for Sprint2 branch

4edc7ed

update to lookup function and test for passing correct array

0eba06a

update to Sprint 2 lookup function and tests including testing of unh…

cba3098

…appy path

update to Sprint 2 querystring updated function and tests

2ee1655

update to Sprint 2 querystring updated function and tests

b004cf4

update to Sprint 2 Contains test update. s

2a7eae5

changes to tally following testing

07a67c7

update to tally and test for all cases

24e9bac

update to invert including tests

728710e

update to invert including tests

45dd976

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026

DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026

updates to querystringtest

f886f54

Merge branch 'main' into sprint-2

aba13bc

cjyuan reviewed Mar 20, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 20, 2026

DamianDL added 5 commits March 24, 2026 14:34

updated recipe.js replacing for loop with .join to simplify code

7adcbd8

Merge branch 'sprint-2' of https://github.com/DamianDL/Module-Data-Gr…

36df520

…oups into sprint-2

updated contains.js replacing Object.prototype.hasOwnProperty() with …

3698abb

…just Object.hasOwnProperty() to simplify code

updated lookup.js and resaved to enable Prettier formatting

fbd948c

updated tally.js and test to expand testing for strings

9879390

DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 24, 2026

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 24, 2026

DamianDL mentioned this pull request Mar 30, 2026

Jan 26 ITP London | Data Groups | Damian Dunkley DamianDL/My-Coursework-Planner#38

Open

illicitonion closed this May 4, 2026

Uh oh!

Conversation

DamianDL commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

DamianDL Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

DamianDL Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

DamianDL Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan commented Mar 24, 2026

Uh oh!

illicitonion commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DamianDL commented Mar 11, 2026 •

edited

Loading