WestMidlands | 26_ITP_Jan | Tasleem Adedokun | sprint 1| Wireframe to webcode#1061
WestMidlands | 26_ITP_Jan | Tasleem Adedokun | sprint 1| Wireframe to webcode#1061tasleemadedokun wants to merge 9 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
Code is free of syntax error and well indented. Good job.
To better align with the wireframe, can you center the PAGE TITLE and the SHORT DESCRIPTIUON beneath the title?
|
I have done the corrections. Thank you very much.
…On Tue, 3 Feb 2026, 21:57 CJ Yuan, ***@***.***> wrote:
***@***.**** commented on this pull request.
Code is free of syntax error and well indented. Good job.
To better align with the wireframe, can you center the PAGE TITLE and the
SHORT DESCRIPTIUON beneath the title?
—
Reply to this email directly, view it on GitHub
<#1061 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B2G4CKTWZ63GQV7DCH35TBL4KEKWNAVCNFSM6AAAAACS22ZBZWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTONBXHAYTCNRUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Did you forget to push (sync) the changes to GitHub? |
|
I am confused. So sorry
…On Wed, 4 Feb 2026, 21:28 CJ Yuan, ***@***.***> wrote:
*cjyuan* left a comment (CodeYourFuture/Module-Onboarding#1061)
<#1061 (comment)>
Did you forget to push (sync) the changes to GitHub?
—
Reply to this email directly, view it on GitHub
<#1061 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B2G4CKTEIDZL6SEH745MP2D4KJP6PAVCNFSM6AAAAACS22ZBZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNBZHAZTEMJWHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Well, sometimes I still get confused with all these processes. I am so sorry to disturb you. I think I have sync changes. |
|
I don't see any new commits on GitHub. If you have made changes and committed them on your computer, you only updated your local clone. To also applied the changes on GitHub, you would need to push the commits to GitHub (remote). Try looking up how to sync local repo with remote repo on VSCode. |
Hi @cjyuan, I finally figured out I had two branches of wireframes, and I was making changes to the wrong one. I have deleted the wrong branch, and I have made the changes to the right wireframe branch as requested. |
|
Great job in figuring out the issue and resolved it! Changes look good. Well done. |
Thank you very much. |
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |

Learners, PR Template
Self checklist
Changelist
Brief Description;
To the best of my ability, I have been able to replicate a wireframe page, following the README file instructions, and ensured it met the accessibility standard
Questions
no question