Skip to content

Revert pr template #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Grajales-K wants to merge 31 commits into from
Closed

Revert pr template #937

Grajales-K wants to merge 31 commits into from

Conversation

@Grajales-K
Copy link

@Grajales-K Grajales-K commented Jan 9, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Grajales-K
tick the check list in the PR
9100029
@Grajales-K
added a new section and 2 articles
d510d37
@Grajales-K
added border to visualize the how clamp works in main
db40dd0
@Grajales-K
added some blue style and center the header
9b30f12
@Grajales-K
update the var --space to make more smooth the transition
4920811
@Grajales-K
added title and a paragraph in the header
bdf22cb
@Grajales-K
added img for section and article
1dbaa49
@Grajales-K
changed the color of h3
1ee5ade
@Grajales-K
added information, titles and href in the buttons
4362903
@Grajales-K
updated and organized the code following the structure of its html
a2e4d09
@Grajales-K
added some options for wireframe img tag
9714b8e
@Grajales-K
update text in the main section and first article
7121945
@Grajales-K
update stylish of buttons and text
eb79083
@Grajales-K
resized images to fit in its containers
00cc5df
@Grajales-K
refactor: improve SEO and accessibility for onboarding page
5f6b40d 
- Added meta description for better SEO indexing.
- Added descriptive alt text to all images for screen readers.
- Standardized image dimensions to prevent layout shifts and improve rendering.
@Grajales-K
added to the tag anchor
6152f4b 
-aria-label
- target: to open a new tab
@Grajales-K
fixed
19546d9 
-href in each anchor
@Grajales-K
added
46ba5d8 
-hover to the anchor
-effects before and after
@Grajales-K
briefly explanation of the project
b0dfa1a
@Grajales-K
added details to the footer and favicons
b3cca68
@Grajales-K
updated
41cd87a 
-link in the head fot the social Icons

- added class to anchor in the main

- update the footer section
@Grajales-K
updated
830e651 
-class fot buttons to the anchor main section

- style for the footer
@Grajales-K
uploaded favicon
b5ac48b
@Grajales-K
added Notes.md for important information of this project
84b8ebe
@Grajales-K
cleanning style file and move info to notes.
930f57f
@Grajales-K
removed spaces unused
a31a003
@Grajales-K
added defer en the head to the tag script to better render
544f1a0
@Grajales-K
removed space
f79de95
@Grajales-K
PR templante orginal version and removed changes
cba935f
@Grajales-K
PR templante orginal version and removed changes
5594ff1
@Grajales-K
Delete .github/pull_request_template.md
085d56d 
I will delete this because some files are causing conflict
@netlify
Copy link

netlify bot commented Jan 9, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 085d56d
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/696181c943cdf50008360b77
😎 Deploy Preview https://deploy-preview-937--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 99 (🔴 down 1 from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Grajales-K Grajales-K closed this Jan 9, 2026
@Grajales-K Grajales-K deleted the revert-pr-template branch January 9, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Grajales-K