Sheffield | 26-ITP-Jan | Daniel Aderibigbe | Sprint 2 | Form Controls#973
Closed
Dan2Clouted wants to merge 3 commits intoCodeYourFuture:mainfrom
Closed
Sheffield | 26-ITP-Jan | Daniel Aderibigbe | Sprint 2 | Form Controls#973Dan2Clouted wants to merge 3 commits intoCodeYourFuture:mainfrom
Dan2Clouted wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
reviewed
Jan 18, 2026
Comment on lines
+20
to
+26
| <input | ||
| type="text" | ||
| id="name" | ||
| required | ||
| name="customerName" | ||
| minlength="2" | ||
| /> |
Contributor
There was a problem hiding this comment.
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter validation rule using the pattern attribute to disallow any name that contains only space characters?
Co-authored-by: CJ Yuan <cjyuan00@gmail.com>
Contributor
|
Well done! Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:
|
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Self Checklist
Changelist
I build a form using semantic HTML using fieldset and legend tags, added required inputs for name and email validation and achieved a 100 in my LightHouse Accessibility.