-
-
Notifications
You must be signed in to change notification settings - Fork 118
separate backlog into sections #1687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-itd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
illicitonion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Also left a few comments on Slack
|
In recent changes:
|
I think the padding is making this harder to read, rather than easier.
illicitonion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a couple of commits, PTAL!
I also added labels to the "Welcome" sprint so they show up.
I audited the Welcome sprint and the first two modules, and noticed on https://deploy-preview-1687--cyf-programming.netlify.app/onboarding/sprints/3/backlog/ that "Step1: Onboarding" is a prereq of "Enroll as a Trainee" but is lower down (Note also that "Join Codewars" is a prereq of "Step1: Onboarding")

What does this change?
This separates the backlog pages for each sprint into four sections:
New labels have been added for issues which correspond to these categories:
SetupRecurringCore(avoidingMandatoryfor now as there's already a label with a similar name, but can always change it later)OptionalA section will not be rendered if there are no issues in that sprint with the corresponding label.
Most changes are made in
backlog.htmlbutbacklog-issue.htmlhas been created to avoid duplicating HTML. I looked into modifying theissue.htmlpartial instead but this had unintended side-effects. Long-term I'll revisit this.Next step is reformatting issues for consistency, then revisiting the HTML/CSS if necessary.
Common Content?
Common Theme?
Yes
Modifies
backlog.htmlto filter issues by priority then build each section in turn. This can definitely be improved, there's a lot of repetition currentlyUpdates the query in
issues-list-as-blocks.htmlto allow all labels to be pulled from the APIOrg Content?
Module|Sprint| Page Type |Block TypeChecklist
Who needs to know about this?
@illicitonion
@LonMcGregor
@Poonam-raj