Skip to content

fix: fatal error on servers with broken FTP filesystem configuration #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HardeepAsrani wants to merge 1 commit into
base: development
Choose a base branch
from
+38 −35
Open

fix: fatal error on servers with broken FTP filesystem configuration #1258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 38 additions & 35 deletions classes/Visualizer/Module.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,50 +529,53 @@ protected function get_user_customization_js() {
return $default;
}

require_once( ABSPATH . 'wp-admin/includes/file.php' );
WP_Filesystem();
global $wp_filesystem;
if ( ! is_a( $wp_filesystem, 'WP_Filesystem_Base' ) ) {
$creds = request_filesystem_credentials( site_url() );
wp_filesystem( $creds );
}
try {
require_once( ABSPATH . 'wp-admin/includes/file.php' );
WP_Filesystem();
global $wp_filesystem;
if ( ! is_a( $wp_filesystem, 'WP_Filesystem_Base' ) ) {
return $default;
}

$multisite_arg = '/';
if ( is_multisite() && ! is_main_site() ) {
$multisite_arg = '/sites/' . get_current_blog_id() . '/';
}
$multisite_arg = '/';
if ( is_multisite() && ! is_main_site() ) {
$multisite_arg = '/sites/' . get_current_blog_id() . '/';
}

$dir = $wp_filesystem->wp_content_dir() . 'uploads' . $multisite_arg . 'visualizer';
$file = $wp_filesystem->wp_content_dir() . 'uploads' . $multisite_arg . 'visualizer/customization.js';
$dir = $wp_filesystem->wp_content_dir() . 'uploads' . $multisite_arg . 'visualizer';
$file = $wp_filesystem->wp_content_dir() . 'uploads' . $multisite_arg . 'visualizer/customization.js';

if ( $wp_filesystem->is_readable( $file ) ) {
return $specific;
}

if ( $wp_filesystem->exists( $file ) && ! $wp_filesystem->is_readable( $file ) ) {
do_action( 'themeisle_log_event', Visualizer_Plugin::NAME, sprintf( 'Unable to read file %s', $file ), 'error', __FILE__, __LINE__ );
return $default;
}
if ( $wp_filesystem->is_readable( $file ) ) {
return $specific;
}

if ( ! $wp_filesystem->exists( $dir ) ) {
// phpcs:ignore WordPress.CodeAnalysis.AssignmentInCondition.Found
if ( ( $done = $wp_filesystem->mkdir( $dir ) ) === false ) {
do_action( 'themeisle_log_event', Visualizer_Plugin::NAME, sprintf( 'Unable to create directory %s', $dir ), 'error', __FILE__, __LINE__ );
if ( $wp_filesystem->exists( $file ) && ! $wp_filesystem->is_readable( $file ) ) {
do_action( 'themeisle_log_event', Visualizer_Plugin::NAME, sprintf( 'Unable to read file %s', $file ), 'error', __FILE__, __LINE__ );
return $default;
}
}

// if file does not exist, copy.
if ( ! $wp_filesystem->exists( $file ) ) {
$src = str_replace( ABSPATH, $wp_filesystem->abspath(), VISUALIZER_ABSPATH . '/js/customization.js' );
// phpcs:ignore WordPress.CodeAnalysis.AssignmentInCondition.Found
if ( ( $done = $wp_filesystem->copy( $src, $file ) ) === false ) {
do_action( 'themeisle_log_event', Visualizer_Plugin::NAME, sprintf( 'Unable to copy file %s to %s', $src, $file ), 'error', __FILE__, __LINE__ );
return $default;
if ( ! $wp_filesystem->exists( $dir ) ) {
// phpcs:ignore WordPress.CodeAnalysis.AssignmentInCondition.Found
if ( ( $done = $wp_filesystem->mkdir( $dir ) ) === false ) {
do_action( 'themeisle_log_event', Visualizer_Plugin::NAME, sprintf( 'Unable to create directory %s', $dir ), 'error', __FILE__, __LINE__ );
return $default;
}
}

// if file does not exist, copy.
if ( ! $wp_filesystem->exists( $file ) ) {
$src = str_replace( ABSPATH, $wp_filesystem->abspath(), VISUALIZER_ABSPATH . '/js/customization.js' );
// phpcs:ignore WordPress.CodeAnalysis.AssignmentInCondition.Found
if ( ( $done = $wp_filesystem->copy( $src, $file ) ) === false ) {
do_action( 'themeisle_log_event', Visualizer_Plugin::NAME, sprintf( 'Unable to copy file %s to %s', $src, $file ), 'error', __FILE__, __LINE__ );
return $default;
}
}
}

return $specific;
return $specific;
} catch ( \Throwable $e ) {
return $default;
}
}

/**
Expand Down
Loading