Skip to content

fix: prevent double clipboard alert on copy action #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HardeepAsrani wants to merge 1 commit into
base: development
Choose a base branch
from
+4 −3
Open

fix: prevent double clipboard alert on copy action #1265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions js/render-facade.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
/* global visualizer */
/* global jQuery */
var vizClipboard1=null;
var vizClipboard2=null;
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Since this is local, I think we can use let instead of var.

(function($, visualizer){

function initActionsButtons(v) {
Expand All @@ -13,12 +14,12 @@ var vizClipboard1=null;
});
}

if($('a.visualizer-action[data-visualizer-type=copy]').length > 0) {
if($('a.visualizer-action[data-visualizer-type=copy]').length > 0 && vizClipboard2 === null) {
$('a.visualizer-action[data-visualizer-type=copy]').on('click', function(e) {
e.preventDefault();
});
var clipboard = new ClipboardJS('a.visualizer-action[data-visualizer-type=copy]'); // jshint ignore:line
clipboard.on('success', function(e) {
vizClipboard2 = new ClipboardJS('a.visualizer-action[data-visualizer-type=copy]'); // jshint ignore:line
vizClipboard2.on('success', function(e) {
window.alert(v.i10n['copied']);
});
}
Expand Down
Loading