fix: filter icon fields from manifests to prevent csp violations #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewduncan
force-pushed
the
fix-extension-icon-csp-violations
branch
from
f4ff978 to
9ded1ee
Compare
|
🎉 This PR is included in version 18.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Terraform extension was causing Content Security Policy violations in the browser console with errors like:
The HashiCorp Terraform extension puts custom icons in its package.json manifest:
The rollup-vsix-plugin has a bug that fails to detect and bundle these icon paths properly.
Need to filter out icon-related fields from extension manifests: