VSCode 1.107 #753
Merged
VSCode 1.107 #753
+4,954
−2,301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 12, 2025 17:15
CGNonofr
force-pushed
the
lmn/vscode-1.107
branch
from
1c85ad7 to
8c9c6ba
Compare
added 3 commits
December 15, 2025 17:02
Use getWorkerUrl instead of getWorker to let VSCode instantiate the Worker itself, as it already includes the cross original worker logic, and also to homogenize with the extension host worker, which only uses getWorkerUrl
CGNonofr
force-pushed
the
lmn/vscode-1.107
branch
from
8c9c6ba to
79d5ce4
Compare
Collaborator
|
@CGNonofr so now we can override where the extension host worker is loaded from? |
kaisalmen
approved these changes
Dec 16, 2025
Collaborator
kaisalmen
left a comment
kaisalmen
left a comment
There was a problem hiding this comment.
LGTM. Thank you. As usual, I will test this downstream.
Contributor
Author
Can you explain a bit what you mean? do you mean in the code? or the url? I don't expect it to be more than a refactor 🤔 |
Collaborator
|
There is a default, but you can override it, of course. That is done in one or two example and the mentioned tests. I think I need to adjust the above code. |
|
🎉 This PR is included in version 24.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.