Refactor common packages #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 17, 2025 16:33
let it resolve, so the module is not marked as external and doesn't infer with the subpackage plugin
to drastically reduce the number of common packages, and make them predictable by just keeping common packages with dependencies the main package doesn't depend on
it allows for instance to disable extension gallery signature
CGNonofr
force-pushed
the
lmn/reduce-package-count
branch
from
f93828b to
fd7575c
Compare
Collaborator
|
@CGNonofr wow, I didn't expect such a change. That sounds good. How confident are you it is working properly? |
Contributor
Author
Quite confident! And it will be a new major version, so it's probably not a big issue if the first version of a new major version is broken |
kaisalmen
approved these changes
Dec 18, 2025
Collaborator
kaisalmen
left a comment
kaisalmen
left a comment
There was a problem hiding this comment.
LGTM. Let's test this fully downstream...
|
🎉 This PR is included in version 24.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop generating *-common packages with uuids
Instead, try to merge them as much as possible with each others and with the main package, at the only condition that it doesn't add additional external dependencies (xterm, xterm addons, katex...)
Name the common packages with the external dependencies they are pulling (instead of uuids) so it's more predictable