fix: respect isRegExp option in WorkspaceSearchProvider #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

nk-coding wants to merge 1 commit into CodinGame:main from nk-coding:main

+8 −7

nk-coding commented Dec 19, 2025 •

edited

Loading

Fixes #756

I tested it using the demo, seem to work fine

Note:
vscode sets multiline and unicode always to true, regardless of the parameters (https://github.com/microsoft/vscode/blob/eba6411f8aee3458c64046b5af0b68ea801fae40/src/vs/workbench/services/search/worker/localFileSearch.ts#L300C10-L300C28). I kept using the parameters here, like the previous implementation. I do not know which is the better approach

Edit: I guess this also fixes isWordMatch


          fix: respect isRegExp option in WorkspaceSearchProvider

65f8911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet