feat(medcat den): CU-869bt6xtk Allow pushing models without change #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ription that changes in model card when saving with change description
Member
mart-r
deleted the
feat/medcat-den/CU-869bt6xtk-allow-pushing-without-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is normally not a good idea. The user is expected only to push models if/when they've made changes to them.
However, when pushing a brand new model (e.g when moving models between back ends / syncing) we need to do that. Otherwise the resulting model would have a different model card due to the changes in the description.
Normally this isn't much of an issue (the hash and the rest of the model card still remain the same). However, when syncing we do want to ensure that we end up with the same exact models.
Though - somewhat notably - the re-saving of a model will still change the
Last Modified Onand (potentially)MedCAT Versionvalues. But I've left them be for now.