bug(medcat-den): CU-869btgwzz Fix base model identification #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base models (for the sake of the den at least) are ones for which we do not have a parent model. That is because there may be (and generally is) multiple steps (e.g model creation, self-supervised training, supervised training) to creating a base model. And we do not want to provide models half-way through this process. The previous logic relied on the model history having something more than 1 hash, but that does not work with the exepcted logic
Member
tomolopolis
approved these changes
Jan 16, 2026
| def has_model(self, model_info: ModelInfo) -> bool: | ||
| # TODO: improve! Is there an API endpoint to call? | ||
| for model in self.list_available_base_models(): | ||
| if model.model_id == model_info.model_id: |
Member
There was a problem hiding this comment.
return model.model_id == model_info.model_id
Collaborator
Author
There was a problem hiding this comment.
That would only check against the first model in the list. And if that doesn't match, it'd return False. The matching model may still be further down the list.
mart-r
deleted the
bug/medcat-den/CU-869btgwzz-fix-base-model-identification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base models (for the sake of the den at least) are ones for which we do not have a parent model. That is because there may be (and generally is) multiple steps (e.g model creation, self-supervised training, supervised training) to creating a base model. And we do not want to provide models half-way through this process.
The previous logic relied on the model history having something more than 1 hash, but that does not work with the exepcted logic.
This PR fixes the issue by:
ModelInfo.base_modeltoNonein theLocalFileDenimplementation upon push if/when the model does not have a parent available.