bug(medcat-den): CU-869bu4tum Fix wrapper save #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MedCAT-Den uses a a class that wraps the
medcat.cat.CATclass (medcat_den.wrappers.CATWrapper). The point of it is to not allow the model to be saved onto disk (under normal circumstances). This is because the idea is to use the wrapped model (that's received from a den) locally and only save it in the back end (hopefully MedCATtery) so that all the changes are kept track of.However, when the model is in fact saved on disk (e.g for a local version of the den) the models were saved as if they were (exclusively!) of the wrapper type. This mean that things that didn't have access to
medcat_denwere unable to load these models. For instance, when pushing one of these to the remote MedCATtery, the latter would be unable to load it.This PR addresses the issue by calling the
CAT.save_model_packexplicitly to make sure that the instnace is treated asCATrather thanCATWrapper. A simple test was also added. This would fail in the previous implementation (I checked).