Asaf Axelrod ShowCard integration (useState exercise)#6
Open
AxelrodAsaf wants to merge 1 commit intoColmanDevClubORG:mainfrom
Open
Asaf Axelrod ShowCard integration (useState exercise)#6AxelrodAsaf wants to merge 1 commit intoColmanDevClubORG:mainfrom
AxelrodAsaf wants to merge 1 commit intoColmanDevClubORG:mainfrom
Conversation
Tamir198
requested changes
Dec 16, 2025
| // true → "This show is in your interested list 🎟️" | ||
| if (props.ticketsLeft === 0) { | ||
| ticketsStatusText = "SOLD OUT"; | ||
| } else if (props.ticketsLeft <= 30) { |
Member
There was a problem hiding this comment.
When we have number hardcoded inside the code like this ("magic number") its very confusing to the next developer.
So save all of you numbers inside constant variables
| if (props.ticketsLeft === 0) { | ||
| ticketsStatusText = "SOLD OUT"; | ||
| } else if (props.ticketsLeft <= 30) { | ||
| ticketsStatusText = "Last tickets – hurry up!"; |
Member
There was a problem hiding this comment.
You could use ternary in here, also save your hardcoded strings into constant file
| {/* TODO 7: If isInterested → show ⭐ before artist name */} | ||
| "Artist name here" | ||
| {isInterested ? "⭐ " : ""} | ||
| {props.artist} |
| <div className="shows-grid"> | ||
| {/* TODO - shows.map((show)=>{ return <ShowCard id={show.id} .../> })*/} | ||
| {shows.map((show) => { | ||
| return <ShowCard key={show.id} {...show} />; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.