Skip to content

Bump OpenTelemetry version to 1.0 and fix SpanData Resource#178

Open
HaloFour wants to merge 6 commits intoComcast:masterfrom
HaloFour:otel-1.x
Open

Bump OpenTelemetry version to 1.0 and fix SpanData Resource#178
HaloFour wants to merge 6 commits intoComcast:masterfrom
HaloFour:otel-1.x

Conversation

@HaloFour
Copy link
Copy Markdown
Collaborator

@HaloFour HaloFour commented Apr 10, 2021

Bumps the OpenTelemetry version to 1.0 (1.1 is out but I want to make sure that the API remains compatible with the 1.0 release for the time being).

Renames SpanInfo.Event and SpanInfo.Link to EventInfo and LinkInfo respectively, to keep in the convention of OpenTelemetry.

Also fixes an issue exporting Money spans to OpenTelemetry SDK exporters where the Resource is not populated with the service name. Added service name and host name from the SpanInfo.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.99%. Comparing base (15d23cd) to head (1cfce63).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
.../scala/com/comcast/money/wire/SpanConverters.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   93.90%   93.99%   +0.08%     
==========================================
  Files          93       93              
  Lines        1247     1248       +1     
  Branches       83       84       +1     
==========================================
+ Hits         1171     1173       +2     
+ Misses         76       75       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants