[RangeSelector] Add support for vertical orientation #756
Conversation
|
@dotnet-policy-service agree |
There was a problem hiding this comment.
Pull request overview
This PR adds vertical orientation support to the RangeSelector control, allowing it to be displayed vertically in addition to the existing horizontal orientation. The implementation includes proper coordinate inversion for vertical mode (top = maximum value, bottom = minimum value), visual state management, and support for keyboard, pointer, and drag interactions in both orientations.
Key Changes
- Added
Orientationdependency property with horizontal/vertical support - Implemented coordinate inversion logic for vertical mode across all input methods
- Added visual states for orientation with appropriate XAML template adjustments
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| RangeSelector.xaml | Added OrientationStates visual state group with layout adjustments for vertical mode |
| RangeSelector.cs | Added visual state constants, Loaded event handler for initial sync, and orientation-aware SyncThumbs/SyncActiveRectangle methods |
| RangeSelector.Properties.cs | Added Orientation property with change callback that updates visual states and syncs thumbs |
| RangeSelector.Input.Pointer.cs | Updated pointer event handlers to support vertical coordinate system with proper inversion |
| RangeSelector.Input.Key.cs | Added Up/Down key support for vertical mode and refactored keyboard handling |
| RangeSelector.Input.Drag.cs | Added DragThumbVertical method and updated drag handlers for vertical orientation |
| RangeSelector.md | Added documentation section for vertical orientation with sample reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Illustar0
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Illustar0
force-pushed
the
feat/allow-vertical-rangeselector
branch
from
63e4657 to
5968456
Compare
2 participants
Fixes #755
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No vertical orientation support for RangeSelector control.
What is the new behavior?
Add vertical orientation support for RangeSelector control.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information