Merged
Conversation
This option is never useful as you can't have a fitted calibration for a model that doesn't exist yet.
…add user friendly entry point for calibration of PSMs
…bration. Linear calibration improvements: - Set defaults to 20 splits and use_median false to avoid jagged calibration lines - Introduce min_samples_per_segment to avoid setting badly fit anchor points in sparse RT regions
…n every model load
Introduce min_samples_per_segment option to avoid overfitting in sparsely populated sections; set sensible default parameters to 10 splits and 20 min_samples_per_segment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
coreto avoid code duplication and add user friendly entry point for calibration of PSMsmin_samples_per_segmentto avoid setting badly fit anchor points in sparse RT regionsChanged
_featuresmodule; add todo for fixed modificationsuse_medianfalse to avoid jagged calibration lines; introducemin_samples_per_segmentto avoid setting badly fit anchor points in sparse RT regionsFixed
Removed
finetune_and_predict: This option is never useful as you can't have a fitted calibration for a model that doesn't exist yet.