feat: Make Literal wrapper of Predicate#398
Draft
ImkoMarijnissen wants to merge 13 commits intomainfrom
Draft
Conversation
Contributor
|
It might be a good idea to briefly describe what has been done, the main idea, and the main change. It would make reviewing easier. |
Contributor
|
A few thoughts on this:
|
… finding watchers for literals when negated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #375.
This PR aims to move away from having to create a fresh variable for each
Literalby making it a wrapper around aPredicate.Any feedback on this PR is welcome!
TODOs
bool2intand the boolean equals constraint since it has a list ofLiterals as input, which sum up to aDomainId, which means that the scaling trick does not work.notifyinstead ofnotify_predicate.Predicatemultiple times). This breaks some of the invariants that we have for certain propagators, so these should be double-checked.to_integer_variablebeing removed.