feat(pumpkin-solver): Expose version and git commit in crate#404
Merged
maartenflippo merged 2 commits intomainfrom Mar 31, 2026
Merged
feat(pumpkin-solver): Expose version and git commit in crate#404maartenflippo merged 2 commits intomainfrom
maartenflippo merged 2 commits intomainfrom
Conversation
The version and git commit hash are included as `env!()` variables. For the git commit hash, we use vergen to emit the appropriate variables. Closes #268.
ImkoMarijnissen
approved these changes
Mar 30, 2026
Contributor
|
This is a very welcome addition! Question: Where should we print the information about the commit hash? Should this be a command line parameter that just prints the version, or should we print it somewhere else? |
Contributor
Author
I think it makes sense to always log this information. That way we always know which version of the solver produced a log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version and git commit hash are included as
env!()variables. For the git commit hash, we use vergen to emit the appropriate variables.Closes #268.