fix: Time-table checker not detecting conflicts properly#405
Merged
ImkoMarijnissen merged 4 commits intomainfrom Apr 1, 2026
Merged
fix: Time-table checker not detecting conflicts properly#405ImkoMarijnissen merged 4 commits intomainfrom
ImkoMarijnissen merged 4 commits intomainfrom
Conversation
This reverts commit b99b962.
maartenflippo
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing time-tabling, a task cannot be propagated by a profile which it is itself in; our propagator relies on the fact that it is called again afterwards, but our checker cannot rely on this information.
This means that the check in the checker for whether a task should have its lower/upper-bound moved was incorrect. I have added a test case which triggered this behaviour. Additionally, I have significantly simplified the process to avoid possible errors. This will likely result in a hit in performance, if this simplification is not necessary then I can fix it another way.