Extend Alt+drag rubberband to all container widgets#3758
Merged
kasemir merged 1 commit intoControlSystemStudio:masterfrom Mar 31, 2026
Merged
Conversation
Previously, Alt+left-click-drag to start a rubberband selection inside a container only worked for GroupWidget and TabsWidget (hard-coded instanceof checks). Any other container (e.g. ArrayWidget) would still consume the click and select itself instead. Replace the specific instanceof checks with ChildrenProperty.getChildren() != null, which returns non-null for any widget that has a children property. This covers GroupWidget, TabsWidget, ArrayWidget, and any future container types automatically.
|
Author
|
Hi, this is not a bug per se, but a potential improvement to the code, so new container widgets will inherited by default the ALT+drag to select controls in a region behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Alt+left-click-drag to start a rubberband selection inside a container only worked for GroupWidget and TabsWidget (hard-coded instanceof checks). Any other container (e.g. ArrayWidget) would still consume the click and select itself instead.
Replace the specific instanceof checks with ChildrenProperty.getChildren() != null, which returns non-null for any widget that has a children property. This covers GroupWidget, TabsWidget, ArrayWidget, and any future container types automatically.