Skip to content

fix: use @model.bucket instead of CouchbaseOrm::Connection.bucket in delete_all #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pimpin merged 1 commit into from
Feb 24, 2026
Merged

fix: use @model.bucket instead of CouchbaseOrm::Connection.bucket in delete_all #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/couchbase-orm/relation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def [](*args)
def delete_all
CouchbaseOrm::logger.debug{ "Delete all: #{self}" }
ids = query.to_a
CouchbaseOrm::Connection.bucket.default_collection.remove_multi(ids) unless ids.empty?
@model.bucket.default_collection.remove_multi(ids) unless ids.empty?
Copy link

@gemini-code-assist gemini-code-assist bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The unless ids.empty? check is unnecessary. The Couchbase SDK's remove_multi method handles an empty array of IDs gracefully by performing a no-op. Removing this conditional check simplifies the code and relies on the idiomatic behavior of the SDK.

                @model.bucket.default_collection.remove_multi(ids)

end

def where(string_cond=nil, **conds)
Expand Down