Skip to content

removed force/check option for put_block#702

Open
manuschneider wants to merge 3 commits intomasterfrom
remove_putblock_force
Open

removed force/check option for put_block#702
manuschneider wants to merge 3 commits intomasterfrom
remove_putblock_force

Conversation

@manuschneider
Copy link
Collaborator

Fixes #501

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

❌ Patch coverage is 14.28571% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.25%. Comparing base (e87c3a2) to head (c987912).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
include/UniTensor.hpp 15.38% 18 Missing and 4 partials ⚠️
src/UniTensor_base.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   32.35%   35.25%   +2.90%     
==========================================
  Files         215      215              
  Lines       36363    33101    -3262     
  Branches    14597    13192    -1405     
==========================================
- Hits        11764    11670      -94     
+ Misses      22659    19517    -3142     
+ Partials     1940     1914      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IvanaGyro
Copy link
Collaborator

This breaks Python API. I suggest deprecate the API first if we are not planning to release version 2.

@manuschneider
Copy link
Collaborator Author

This breaks Python API. I suggest deprecate the API first if we are not planning to release version 2.

Since there is no use case for this (see #501), I do not think than this option was really used.

If we still want to make the API deprecated first, how would this work? Do we have a standard procedure that warns users when they use a feature that is deprecated?

@IvanaGyro
Copy link
Collaborator

Since there is no use case for this (see #501), I do not think than this option was really used.

The function signature is changed. If someone use it, their code will be broken.

If we still want to make the API deprecated first, how would this work? Do we have a standard procedure that warns users when they use a feature that is deprecated?

You can refer how popular packages did or #672.

@manuschneider
Copy link
Collaborator Author

Since there is no use case for this (see #501), I do not think than this option was really used.

The function signature is changed. If someone use it, their code will be broken.

If we still want to make the API deprecated first, how would this work? Do we have a standard procedure that warns users when they use a feature that is deprecated?

You can refer how popular packages did or #672.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suspicious check in UniTensor::put_block()

3 participants