hotfix: restored missing NOISE_IN_SUBDIR #include-conditional code#1063
hotfix: restored missing NOISE_IN_SUBDIR #include-conditional code#1063tcoyvwac wants to merge 2 commits intoCytopiaTeam:masterfrom
#include-conditional code#1063Conversation
Compiling fails if NOISE_IN_SUBDIR include-route is not defined. Restored conditional-include-code and fixed regression detected onwards from commit: d1e9691.
|
Current Situation:
Expected:
Actual:
Notes: However, looking further, it seems that during a buildchain-refactoring commit: 54385f0 it was moved and renamed... but not included into any parent .cmake file (so not used or called), in this case, I believe it is now a file called "DependenciesConfig.cmake" This means the current Conan CI process is not correctly adding Steps forward: |
|
Thanks for handling this while I have been a terrible dev and basically taken an impromptu hiatus while Life happened...feel free to ping me when you figure out this issue and the tests pass. |
System:
Debian SidProblem:
Cannot compile project.
On some systems,
noise.his not located & defined inside a "noise/" subdirectory.For example, on
Debian Sid, it is located inside the "libnoise/" subdirectory.Fix:
This PR restores missing conditional NOISE_IN_SUBDIR
#include-code and fixed regression detected onwards from commit: d1e96913.