allow extensions to be killed by docker #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmigneault
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the extension scripts created by the Dockerfile would run the log parser code as a subprocess of the main process (PID 1 in the container).
This meant that when the container was stopped, a SIGTERM would be sent to PID 1 which would be killed but the signal would not be passed on to the actual log parser code. This would mean that the log parser code would keep running until the container itself was killed with a SIGKILL.
This changes the extension script to use
execso that the log parser code runs in the main process (PID 1 in the container) so that it can be stopped by a SIGTERM as expected.