Conversation
|
@lifflander this is now fully working, and the optional choice to use the update formulae (or not) is determined by the use of the Currently, the debug verification is performed, by comparing the update vs. full recompute results; until we convince ourselves fully that the update formulae are correctly implemented (and no theoretical errors were made in the paper either...). Follow-on issues as created to keep track of these 2 points. |
|
@lifflander I made some additional testing following our recent conversation, no problem found. Still awaiting your review when you get a chance. |
lifflander
left a comment
lifflander
left a comment
There was a problem hiding this comment.
Overall, this looks great. I've walked through all the update formula and I think they are correct.
…y detected with a configuration non even feasible to begin with and therefore not part of the test harness)
ppebay
deleted the
611-implement-all-update-formulae-and-make-them-optionally-usable
branch
…612) * #611: added the WIP tempered with updates criterion not added so far * #611: pushing the part that now works (still incomplete) * #611: WS cleanup * #611: pushed part of the update formulae that work prior to meeting * #611: added documentation for update code that is complex * #611: finally resolved the hidden bug in the off rank communication update * #611: WS cleanup * #611: values of alpha/beta/delta that exercise load+off-rank comm+homing * #611: restored synthetic block default config as per PR review * #613: cherry picked changes where the memory error was serendipitously detected with a configuration non even feasible to begin with and therefore not part of the test harness)
2 participants
Resolves #611