[CHORE] design-tokens 자동 반영#23
Closed
khyeji98 wants to merge 2 commits into
Closed
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| public static let borderRadius250: CGFloat = 12 | ||
| public static let borderRadius300: CGFloat = 16 | ||
| public static let borderRadius400: CGFloat = 24 | ||
| public static let borderRadius50: CGFloat = 2 |
There was a problem hiding this comment.
⚪ [P5] Nitpick
일부 숫자 기반 토큰(borderRadius50)이 비순차적으로 선언되어 있습니다. 자동 생성된 코드이므로 기능상 문제는 없으나, 가독성을 위해 토큰 이름의 숫자 순서대로 정렬되는 것이 좋습니다. 이는 디자인 토큰 생성 스크립트 설정으로 개선할 수 있을 것입니다.
| public static let opacity200: CGFloat = 0.16 | ||
| public static let opacity300: CGFloat = 0.24 | ||
| public static let opacity400: CGFloat = 0.32 | ||
| public static let opacity50: CGFloat = 0.05 |
There was a problem hiding this comment.
⚪ [P5] Nitpick
일부 숫자 기반 토큰(opacity50)이 비순차적으로 선언되어 있습니다. 자동 생성된 코드이므로 기능상 문제는 없으나, 가독성을 위해 토큰 이름의 숫자 순서대로 정렬되는 것이 좋습니다. 이는 디자인 토큰 생성 스크립트 설정으로 개선할 수 있을 것입니다.
| public static let spacing350: CGFloat = 20 | ||
| public static let spacing400: CGFloat = 24 | ||
| public static let spacing450: CGFloat = 28 | ||
| public static let spacing50: CGFloat = 2 |
There was a problem hiding this comment.
⚪ [P5] Nitpick
일부 숫자 기반 토큰(spacing50)이 비순차적으로 선언되어 있습니다. 자동 생성된 코드이므로 기능상 문제는 없으나, 가독성을 위해 토큰 이름의 숫자 순서대로 정렬되는 것이 좋습니다. 이는 디자인 토큰 생성 스크립트 설정으로 개선할 수 있을 것입니다.
UIColor → SwiftUI.Color 교체 및 DesignTokenShadow에 Sendable 적합성 추가
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
자동 생성된 디자인 토큰 반영
Source:
zizizoi0709-p/design-tokens@e7c153b4546582551fc6ae378c460fade9a2fa0eTrigger:
pushonmainWorkflow run: #1
Branch:
chore/design-tokens-sync-20260511-154923→develop변경된 파일 (베이스:
Projects/Shared/DesignSystem/)Resources/Colors.xcassets/(Asset Catalog)Sources/Color/Generated/Colors+Generated.swiftSources/CustomFont/Generated/Typography+Generated.swiftSources/Tokens/Generated/Spacing+Generated.swiftSources/Tokens/Generated/Sizing+Generated.swiftSources/Tokens/Generated/BorderRadius+Generated.swiftSources/Tokens/Generated/BorderWidth+Generated.swiftSources/Tokens/Generated/Opacity+Generated.swiftSources/Tokens/Generated/BoxShadow+Generated.swift머지 후 작업
신규 파일이 Xcode 프로젝트에 반영되도록 로컬에서 아래를 실행한다.
./tuisttool generate && tuist graph