feat(DF-789): block save-and-exit and help routes when form is offline#1196
Open
mokhld wants to merge 5 commits into
Open
feat(DF-789): block save-and-exit and help routes when form is offline#1196mokhld wants to merge 5 commits into
mokhld wants to merge 5 commits into
Conversation
jbarnsley10
reviewed
May 14, 2026
| * and renders the unavailable view at HTTP 200. | ||
| * @param {FormMetadata} metadata | ||
| */ | ||
| function assertFormAvailable(metadata) { |
Contributor
There was a problem hiding this comment.
Can these two guard methods be pulled from plugin, so they don't have to be duplicated here? Not a biggy though
Contributor
Author
There was a problem hiding this comment.
Possibly, but it will be a bit more of a refactor. I don't think I have time for it. Possibly tech debt that we can come back to?
jbarnsley10
approved these changes
May 14, 2026
Contributor
jbarnsley10
left a comment
jbarnsley10
left a comment
There was a problem hiding this comment.
Looks good. A v minor comment but approving in principal
…orms-model to 3.0.665 in package.json and package-lock.json
mokhld
force-pushed
the
feat-DF-789-form-offline
branch
from
a3968cc to
117d584
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service-layer wrappers in
formMetadataGuards.jsthrow the offline marker; engine plugin'sonPreResponserenders the unavailable view. Draft until@defra/forms-modelis bumped here.