IM-258 added a datasetRegistry and refactored setStyle#285
Merged
Conversation
dannyleech
reviewed
May 19, 2026
dannyleech
reviewed
May 19, 2026
dannyleech
reviewed
May 19, 2026
dannyleech
reviewed
May 19, 2026
dannyleech
reviewed
May 19, 2026
dannyleech
approved these changes
May 19, 2026
markfee
added a commit
that referenced
this pull request
May 19, 2026
* IM-258 added globals to dataset state * IM-258 added a datasetRegistry * IM-258 stopped flattening styles in mappedDatasets * IM-258 fixed tests in datasets * IM-258 added a dataset class and tests * IM-258 added createDataset factory methods, and a mapLibreSpecific Dataset * IM-258 added layerIds and tests to MapLibreDataset * IM-258 mapLibreDataset.test.js avoids mocking * IM-258 refactored tests and ensured layerIds are not null * IM-258 addLayers/subLayers refactored to use dataset registry * IM-258 added source and sourceId to mapLibreDataset * IM-258 setLayerAdapterActions can take a method name as param * IM-258 ensured setLayerAdapterActions setStyle is only called once per api call * IM-258 fixed _maintainSymbolOrdering, temp rennamed dataset as registryDataset * IM-258 further simplification * IM-258 setSublayerStyle works from the api * IM-258 addSymbolLayer refactored * IM-258 simplified addSymbolLayer * IM-258 simplified addFillLayer * IM-258 simplified addStrokeLayer * IM-258 fixed issue where addStrokeLayer called on a symbol * IM-258 removed unused params from addSublayerLayers * IM-258 removed setSubLayerStyle altogether * IM-258 setSublayerStyle removed from maplibreLayerAdapter * IM-258 removed commented out addSource * IM-258 skipped tests while WIP
markfee
added a commit
that referenced
this pull request
May 20, 2026
* IM-258 added globals to dataset state * IM-258 added a datasetRegistry * IM-258 stopped flattening styles in mappedDatasets * IM-258 fixed tests in datasets * IM-258 added a dataset class and tests * IM-258 added createDataset factory methods, and a mapLibreSpecific Dataset * IM-258 added layerIds and tests to MapLibreDataset * IM-258 mapLibreDataset.test.js avoids mocking * IM-258 refactored tests and ensured layerIds are not null * IM-258 addLayers/subLayers refactored to use dataset registry * IM-258 added source and sourceId to mapLibreDataset * IM-258 setLayerAdapterActions can take a method name as param * IM-258 ensured setLayerAdapterActions setStyle is only called once per api call * IM-258 fixed _maintainSymbolOrdering, temp rennamed dataset as registryDataset * IM-258 further simplification * IM-258 setSublayerStyle works from the api * IM-258 addSymbolLayer refactored * IM-258 simplified addSymbolLayer * IM-258 simplified addFillLayer * IM-258 simplified addStrokeLayer * IM-258 fixed issue where addStrokeLayer called on a symbol * IM-258 removed unused params from addSublayerLayers * IM-258 removed setSubLayerStyle altogether * IM-258 setSublayerStyle removed from maplibreLayerAdapter * IM-258 removed commented out addSource * IM-258 skipped tests while WIP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.