add research info to spectate-overlay#5462
Closed
brmley wants to merge 2 commits intoDFHack:developfrom
brmley:develop
Closed
add research info to spectate-overlay#5462brmley wants to merge 2 commits intoDFHack:developfrom brmley:develop
brmley wants to merge 2 commits intoDFHack:developfrom
brmley:develop
Conversation
Member
|
I haven't moved forward to review this PR because the pre-commit check hasn't been resolved. Is the OP still interested in pursuing this PR? |
Member
|
In any case, this depends on DFHack/scripts#1454 being merged first. The way I understand it, it adds spectate hooks for something that hasn't been merged yet. That being said, it also requires a changelog entry and possibly a mention in the documentation for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes to allow research-info (DFHack/scripts#1454) works with spectate-overlay