Fix df.talk_choice_type def not being up to date for internal/convo.lua#1380
Merged
myk002 merged 2 commits intoDFHack:masterfrom Jan 27, 2025
Merged
Fix df.talk_choice_type def not being up to date for internal/convo.lua#1380myk002 merged 2 commits intoDFHack:masterfrom
myk002 merged 2 commits intoDFHack:masterfrom
Conversation
…convo option, resulting in a nil value being passed
myk002
reviewed
Jan 26, 2025
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
Looks good. Could you add a changelog entry?
Contributor
Author
|
@myk002 ah heck I forgot 😭 |
myk002
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes the extra options not appearing in the conversation menu in the "Ask directions" screen