New Feature: autotraining

[realSquidCoder]

Code for dwarves to hit the gym when they yearn for the gains. Assigns dwarves to a military squad until they have fulfilled their need for Martial Training

[chdoc]

Here are some observations:

1. I'm not particularly fond of the name gym, because it makes me think of using screw pumps to increase strength. Maybe just call it martial-training or martial-arts-class
2. I think the squad should just be chosen from a list, instead of requiring the user to name a squad in a particular way. I think that squads are intended to use DF names, and I would not be surprised if the ability to just input strings would disappear. Maybe, if there is only a single squad that does not have a uniform set, default to that.
3. I would like an option to not automatically replace the squad leader. This way you could actually put a decently skilled teacher in charge of the squad. Also, squad leaders are nobles and this would avoid at least some of the historical figure noise.

[chdoc]

4. It would be nice to have an option to automatically exclude holders of relevant positions (e.g. the manager ...)

[realSquidCoder]

1. I'm not particularly fond of the name `gym`, because it makes me think of using screw pumps to increase strength. Maybe just call it `martial-training` or `martial-arts-class`

Ok thats not a terrible idea. the original name was just needs-training so maybe martial-training works

2. I think the squad should just be chosen from a list, instead of requiring the user to name a squad in a particular way. I think that squads are intended to use DF names, and I would not be surprised if the ability to just input strings would disappear. Maybe, if there is only a single squad that does not have a uniform set, default to that.

the reason you need to make a squad (tho i want to make the script make it's own squad in a later stage) is because it lets you give them the proper schedule and teacher leader.

3. I would like an option to not automatically replace the squad leader. This way you could actually put a decently skilled teacher in charge of the squad. Also, squad leaders are nobles and this would avoid at least some of the historical figure noise.

its not supposed to replace the leader, have you seen it doing that?

[realSquidCoder]

4. It would be nice to have an option to automatically exclude holders of relevant positions (e.g. the manager ...)

you can set up ppl to be ignored but auto ignoring ppl is not a bad idea either. who all should be ignored you think?

[realSquidCoder]

actually, because i intend this to join the automation tab, perhaps autotraining would be a better name

[realSquidCoder]

pre-commit.ci autofix

[ab9rf]

Needs a changelog, otherwise I think this is ready to merge.

[SilasD]

I didn't see anything bad enough to justify delaying a merge.

I have some quibbles with command-line processing and with the enable/disable code.
enable autotraining
disable autotraining
It doesn't appear that these command-line commands will work. (not verified.)

I somewhat question the need for autotraining as a separate script. It seems to me that it could be rolled into gui/autotraining.

[ab9rf]

I somewhat question the need for autotraining as a separate script. It seems to me that it could be rolled into gui/autotraining.
i'm sorry, gui/autotraining? i looked for this and could not find it. to what are you referring?

[chdoc]

This pull-request adds both: autotraining as the tool that performs the actual work and can also be (partially) configured using the command-line and gui/autotraining a graphical interface to configure squads and ignored units. If we want to follow the convention that tools that open windows are invoked as gui/something and tools that perform automation are enabled as enable something we need two commands and therefore two files.

[ab9rf]

Is everyone ok with a squash merge on this one?

[chdoc]

During one of my last sessions I noticed something that I cannot yet explain:

autotraining: 1 training, 12 waiting, and 3 excluded units with training needs

The expected behavior would be 9 training units and 4 waiting units, no?

[realSquidCoder]

@chdoc frack its still doing that? as far as i know that thats a miscount bug not a wrong effect bug, i thought i had fixed all of them tho...

edit: wait no, what i misread that... what is it doing there? (still think we can merge this to get more testers)

[realSquidCoder]

@ab9rf everything seems to have passed so if the others have no issues im cool with a squash and merge. (and of course i'll be around to fix any bugs that are found in the next release)