Conversation
|
This alters user-facing behavior and thus needs a changelog |
|
I'm going to take the slight risk of merging this for release without acceptance testing since it's a straightforward bug fix |
|
Thanks! So GitHub doesn't carry per-commit comments along when it transfers commits to a merge. There's not even an indication that the comments exist. I don't like that. I would guess that's because the comments are not core Git. Edit: I just bet that the comments will disappear when I delete that branch.
Edit: No, they're preserved, just need to click the speech-bubble icon instead of the commit itself. Good to know. |
Two minor fixes to
internal/common/pedestal.lua. No user-visible changes, except that removing items from a pedestal using the DFHack interface will work correctly.Well-tested. Extensive comments in each commit.