Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the JWT privilege handling system to use new token claim fields from the token-exchange-api. The changes replace the previous privilege token middleware with a new implementation from server-garage that uses updated permission constants.
Key changes:
- Updated JWT middleware to use
jwtmiddleware.OneOfPermissionsfrom server-garage package - Replaced privilege constants with new permission constants from token-exchange-api (e.g.,
VehicleCommands→PermissionExecuteCommands) - Updated multiple dependencies including grpc-ecosystem, prometheus, and ethereum libraries to newer versions
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates dependencies to support new JWT middleware and token claims packages, including server-garage v0.0.7 and token-exchange-api v0.3.7 |
| cmd/devices-api/api.go | Migrates from shared/pkg/middleware/privilegetoken to server-garage jwtmiddleware, updates all route handlers to use new permission constants |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
70a251e to
1baf021
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update jwt privilege handler to use new claim permissions and asset