Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the fingerprint validation logic to be more tolerant of invalid VINs during device startup. Previously, if a fingerprint event contained an invalid VIN, the processor would set an error on the message. Now, if an invalid VIN is detected (and it is not a valid Japan Chassis), the processor will simply log a warning and continue processing without marking the message as an error.
Motivation
Some devices may send invalid fingerprints when starting up, which is expected and should not be treated as an error. This change prevents unnecessary error reporting for these cases, improving robustness and reducing noise in logs and monitoring.
Changes
Updated the fingerprint validation processor to:
Log a warning instead of setting an error when an invalid VIN is encountered during device startup.
Continue processing the message batch as normal.
Impact
Reduces false-positive error reporting for fingerprint events with invalid VINs during device startup.
No impact on valid VIN processing or other event types.
Testing
Existing tests for valid and invalid VINs remain in place.
The processor now logs a warning for invalid VINs instead of erroring.