Conversation
- Rename ICEBERG_WAREHOUSE bucket from dimo-iceberg-* to dimo-storage-* across stream configs and Helm values (dev + prod) - Fix import path: cloudeventparquet/encoders -> encoders - Move parseBucket tests into cloudeventtoparquet package and RawEvent_DataBase64 test into encoders; delete parquetwriter_test.go - Update go.mod: add aws-sdk-go-v2 core + s3, drop segmentio/encoding, pin tidwall/match v1.1.1 - Fix struct field alignment in icebergcommit_test.go Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ICEBERG_WAREHOUSES3 bucket fromdimo-iceberg-*todimo-storage-*in stream configs and Helm values (dev + prod)cloudeventparquet/encoders→encoders) and relocate tests:parseBuckettests moved tocloudeventtoparquet,RawEvent_DataBase64moved toencoders; delete orphanedparquetwriter_test.goaws-sdk-go-v2core + S3, dropsegmentio/encoding, pintidwall/matchv1.1.1Test plan
go test ./...passesmake lint-benthos) passes with updated stream configsMade with Cursor