Add Sculpt-O-Sound Vocode-O-Matic module #505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Ugh, I managed not to get the repo included. |
Collaborator
|
Always better to ask for clarification. The Non-Derivative would need an explicit permission if we want to create a dark mode render as well. |
Author
|
I asked; it's specifically CC BY-NC-ND 4.0 (as now mentioned in the changed LICENSE.txt) |
Author
|
Most build failures look like GitHub outages? |
Contributor
|
Please rebase against latest main branch. the windows CI builds are still broken, but the others are ok |
Author
|
(I know sod all about git, sorry) |
falkTX
force-pushed
the
main
branch
8 times, most recently
from
0cba0a1 to
80bda51
Compare
Contributor
|
I cleaned up the PR and created #635 based on it, but it is a "wont-fix" as the modules require 44.1 kHz to work properly which is a blocker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds OK.
plugin.json explicitly has GPL-3.0-or-later for the software; graphics license is mentioned as CC0 in LICENSE.txt, but the newer README.md says CC BY-NC-ND 4.0. Can it considered to be the latter or should I ask the author to clarify?