fix:destroy之后 video 会继续触发事件 #981
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`destroy` 之后 `video` 会继续触发事件。
例如，如果监听了 `error` 事件，因为代码中 `this.video.src = '';` 将视频地址置空，会触发 `MediaError {code: 4, message: "MEDIA_ELEMENT_ERROR: Empty src attribute"}`。
所以组件销毁之后，组件应该不再继续监听事件。
tsukumijima
added a commit
to tsukumijima/DPlayer
that referenced
this pull request
Feb 8, 2022
HiWangyeah
commented
Jul 7, 2022
Contributor
Author
HiWangyeah
left a comment
HiWangyeah
left a comment
There was a problem hiding this comment.
项目还在继续维护么~pr 稍微看一下噻
|
好像是销毁事件之后 on监听 error 还是会执行---， 你有解决吗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destroy之后video会继续触发事件。例如，如果监听了
error事件，因为代码中this.video.src = '';将视频地址置空，会触发MediaError {code: 4, message: "MEDIA_ELEMENT_ERROR: Empty src attribute"}。所以组件销毁之后，组件应该不再继续监听事件。