-
Notifications
You must be signed in to change notification settings - Fork 63
Add profiling barrier option to cmake #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukasdreyer
wants to merge
4
commits into
enhancement-search_timing
Choose a base branch
from
enhancement-profile_barrier
base: enhancement-search_timing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add profiling barrier option to cmake #1906
lukasdreyer
wants to merge
4
commits into
enhancement-search_timing
from
enhancement-profile_barrier
+51
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandro-elsweijer
previously approved these changes
Oct 21, 2025
e49332c to
d8b8486
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## enhancement-search_timing #1906 +/- ##
==========================================================
Coverage 75.64% 75.64%
==========================================================
Files 103 103
Lines 19273 19273
==========================================================
Hits 14580 14580
Misses 4693 4693 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9da423e to
5e8c323
Compare
916d880 to
19c4bc6
Compare
68068ef to
702e98a
Compare
fix variable name in endif statement Co-authored-by: Sandro Elsweijer <49643115+sandro-elsweijer@users.noreply.github.com>
702e98a to
c229d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1908
Describe your changes here:
Introduce profiling barrier option.
TODO: Actually use these before SC_WTIME in communication based timings
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).